Skip to content

Cleanup of old/unused/unmaintained scripts#2087

Merged
alfreb merged 9 commits intoincludeos:devfrom
mnordsletten:jenkins-cleanup
Mar 20, 2019
Merged

Cleanup of old/unused/unmaintained scripts#2087
alfreb merged 9 commits intoincludeos:devfrom
mnordsletten:jenkins-cleanup

Conversation

@mnordsletten
Copy link
Copy Markdown
Contributor

@mnordsletten mnordsletten commented Mar 18, 2019 •
edited
Loading

There might be some controversial removals here so I'll do a quick rundown of what I consider to be safe/questionable.
Then it's up to the reviewers to weigh in and give their opinion.

Safe removals

Old dependency build scripts:

etc/build_binutils.sh
etc/build_chainloader.sh
etc/build_gcc.sh
etc/build_libunwind_nongnu.sh
etc/build_llvm.sh
etc/build_musl.sh
etc/build_newlib.sh
etc/create_binary_bundle.sh
etc/musl/endian.patch
etc/musl/musl.patch
etc/musl/musl_full.patch
etc/musl/syscall.h

Scripts moved to vmrunner package

etc/boot
etc/scripts/create_bridge.sh
etc/scripts/create_memdisk.sh
etc/scripts/grubify.sh
etc/scripts/qemu-ifdown
etc/scripts/qemu-ifup
etc/scripts/solo5-ifup.sh

Old install scripts and OS dependency installation

install.sh
etc/install_clang_version.sh
etc/install_dependencies_linux.sh
etc/install_from_bundle.sh
etc/use_clang_version.sh

Outdated and unused scripts

etc/copy_scripts.sh
.travis.yml
.gitmodules
etc/bash_functions.sh
etc/docker_entrypoint.sh
manual_build.sh
test.sh

Questionable removals

Old ways to run VMs

etc/vboxrun.sh
etc/vmware
etc/scripts/run.sh
etc/bochs_installation.sh
etc/.bochsrc

Various scripts I'm not 100% sure about

analyze.sh
etc/convert_image.sh
etc/internal-scripts/rename_tag.sh
etc/scripts/qemu_cmd.sh
doc/ directory
.clang-format / format_sources.sh
etc/internal-scripts # scripts for applying license, editorconfig, object_sizes.h

Scripts I have not removed, but could be considered removed or moved?

Vagrantfile
./install_on_vagrant.sh
test_solo5_hvt.sh 
etc/debug/service.gdb

@AndreasAakesson
Copy link
Copy Markdown
Contributor

AndreasAakesson commented Mar 18, 2019

Nice overview!

So I'm wondering how you setup a totally clean mac installation today. _macos script does some symlinking and putting binutils in a folder etc.

@mnordsletten
Copy link
Copy Markdown
Contributor Author

mnordsletten commented Mar 18, 2019

install_dependencies_macos.sh is back in action. (for now)

@mnordsletten
Copy link
Copy Markdown
Contributor Author

mnordsletten commented Mar 19, 2019

I also removed the doc directory.

@alfreb alfreb merged commit 3d9cc57 into includeos:dev Mar 20, 2019
@mnordsletten mnordsletten deleted the jenkins-cleanup branch March 26, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fwsGonzo fwsGonzo fwsGonzo approved these changes

@AndreasAakesson AndreasAakesson AndreasAakesson approved these changes

@alfreb alfreb Awaiting requested review from alfreb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mnordsletten @AndreasAakesson @fwsGonzo @alfreb